fix: Chosing cancel on confirmation no longer deletes profiles (#5167) #5176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Dec 6, 2024
.changes/next-release/bugfix-1507b9a1-02ba-426c-b08d-e8ac8ca1e83d.json
Outdated
Show resolved
Hide resolved
…83d.json Co-authored-by: Richard Li <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
) (aws#5176) If the user selects cancel in the confirmation dialog, the sign out will now be aborted. The method logoutFromSsoConnection also calls deleteSsoConnection() if the connection is of type ProfileSsoManagedBearerSsoConnection, so it is does not have to be called from SsoLogoutAction.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
) (aws#5176) If the user selects cancel in the confirmation dialog, the sign out will now be aborted. The method logoutFromSsoConnection also calls deleteSsoConnection() if the connection is of type ProfileSsoManagedBearerSsoConnection, so it is does not have to be called from SsoLogoutAction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Fixes #5167
If the user selects cancel in the confirmation dialog, the sign out will now be aborted.
The method logoutFromSsoConnection also calls deleteSsoConnection() if connection is ProfileSsoManagedBearerSsoConnection, so removing that call from SsoLogoutAction.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.